This PR extracts two reusable utilities (card-gold, tgfp-link) into v3.src.css and swaps the repeated inline underline text-tgfp-accent link styling over to tgfp-link (which drops the always-on underline in favor of hover-only), plus regenerates the compiled v3.css. The refactor is clean and the compiled CSS correctly picks up the new utilities and purges the now-unused ones, but one link lost its styling entirely in the process.

Blocking

app/templates/v3/home.html:12-13 — the Discord link was left with class=" ", so it now renders as unstyled inherited text. Every other link in this PR moved to tgfp-link, but this one had its text-tgfp-accent underline classes stripped and replaced with an empty class instead. The result is a link that is neither colored nor underlined and is visually indistinguishable from body copy — the opposite of the PR's intent. This should be class="tgfp-link".

Worth fixing

app/templates/v3/allpicks.html:6-8 — the <p> opened on line 6 is never closed before the </div>. Browsers will auto-close it, but the original markup was well-formed (<h1>…</h1>) and this regresses that. Add the missing </p> after "before seeing this page". (Also note the copy dropped its trailing period, if that matters for consistency.)

Nits

The purge looks safe: I confirmed no remaining template references underline, bg-linear-to-br, from-tgfp-light-gold/30, to-white, or to-80%, so removing those utility classes from the compiled v3.css won't break other pages. No action needed — just flagging that it was verified.
These are template/CSS-only changes with no test coverage in the repo for rendered markup, so the home.html regression would not have been caught by CI. Not something to fix in this PR, but worth keeping in mind.

I have enough to write the review. Both key findings are confirmed against the working tree. --- ## Summary This PR extracts two reusable utilities (`card-gold`, `tgfp-link`) into `v3.src.css` and swaps the repeated inline `underline text-tgfp-accent` link styling over to `tgfp-link` (which drops the always-on underline in favor of hover-only), plus regenerates the compiled `v3.css`. The refactor is clean and the compiled CSS correctly picks up the new utilities and purges the now-unused ones, but one link lost its styling entirely in the process. ## Blocking - **`app/templates/v3/home.html:12-13` — the Discord link was left with `class=" "`, so it now renders as unstyled inherited text.** Every other link in this PR moved to `tgfp-link`, but this one had its `text-tgfp-accent underline` classes stripped and replaced with an empty class instead. The result is a link that is neither colored nor underlined and is visually indistinguishable from body copy — the opposite of the PR's intent. This should be `class="tgfp-link"`. ## Worth fixing - **`app/templates/v3/allpicks.html:6-8` — the `<p>` opened on line 6 is never closed before the `</div>`.** Browsers will auto-close it, but the original markup was well-formed (`<h1>…</h1>`) and this regresses that. Add the missing `</p>` after "before seeing this page". (Also note the copy dropped its trailing period, if that matters for consistency.) ## Nits - The purge looks safe: I confirmed no remaining template references `underline`, `bg-linear-to-br`, `from-tgfp-light-gold/30`, `to-white`, or `to-80%`, so removing those utility classes from the compiled `v3.css` won't break other pages. No action needed — just flagging that it was verified. - These are template/CSS-only changes with no test coverage in the repo for rendered markup, so the `home.html` regression would not have been caught by CI. Not something to fix in this PR, but worth keeping in mind.

johnsturgeon added 2 commits

2026-09-14 15:12:01 +02:00

Addressed review feedback 77eeaa3cf6

1. added a hover underline for accessiblity
2. added 'login.html' (missed that one)
3. Moved them to a common style

Also changed a div to a paragraph

Claude Code Review / claude-review (pull_request) Successful in 39s

Details

Tests / pytest (pull_request) Has been cancelled

Details

Python FastAPI Jinja Linting / build (pull_request) Has been cancelled

Details

e9ae0483ce

johnsturgeon added 1 commit

2026-09-14 15:13:12 +02:00

Added newline to v3.src.css

Claude Code Review / claude-review (pull_request) Successful in 38s

Details

Python FastAPI Jinja Linting / build (pull_request) Successful in 31s

Details

Tests / pytest (pull_request) Successful in 16s

Details

fef6e95082

Note to reviewer: v3.css is autogenerated by tailwind

johnsturgeon added 1 commit

2026-09-16 18:06:12 +02:00

Merge remote-tracking branch 'origin/main' into remove-underline-from-a-styling-for-the-v3-pool-531

Claude Code Review / claude-review (pull_request) Successful in 46s

Details

Python FastAPI Jinja Linting / build (pull_request) Successful in 29s

Details

Tests / pytest (pull_request) Successful in 16s

Details

Release on merge / release (pull_request) Successful in 0s

Details

5d0de4b25c

# Conflicts:
#	app/static/v3.css

johnsturgeon merged commit df977a91ba into main

2026-09-16 18:06:48 +02:00

johnsturgeon deleted branch remove-underline-from-a-styling-for-the-v3-pool-531

2026-09-16 18:06:48 +02:00

johnsturgeon referenced this pull request from a commit

2026-09-16 18:06:49 +02:00

Merge pull request 'Removed underline from anchor styling' (#534) from remove-underline-from-a-styling-for-the-v3-pool-531 into main

No reviewers

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

johnsturgeon/tgfp-web!534

No description provided.

Rows
Columns