Removed profile and settings pages from the menu #529

Merged
johnsturgeon merged 1 commit from remove-profile-and-settings-pages-from-the-v3-profile-pic-526 into main 2026-09-13 19:35:21 +02:00
Owner

Resolves #526

Resolves #526
Removed profile and settings pages from the menu
All checks were successful
Claude Code Review / claude-review (pull_request) Successful in 20s
Python FastAPI Jinja Linting / build (pull_request) Successful in 32s
Tests / pytest (pull_request) Successful in 17s
Release on merge / release (pull_request) Successful in 0s
ace7681e77
Resolves #526
Author
Owner

The change is a clean, correct removal of two dead placeholder menu links (href="#" Profile and Settings) that had no backing functionality. The dropdown still renders correctly with the player-gated Sign in/Sign out link, and the mobile panel was never affected.

Summary

This PR removes the non-functional "Profile" and "Settings" placeholder links from the account dropdown in app/templates/v3/base.html, resolving #526. It's a purely subtractive template edit with no logic changes and nothing left dangling.

Looks good — ship it.

(Nit, non-blocking and pre-existing, not introduced here: the remaining Sign in / Sign out links in app/templates/v3/base.html:63 and :65 are still href="#" stubs. If they're also unwired, they may be worth tracking in a follow-up, but that's outside the scope of this change.)

<!-- claude-code-review --> The change is a clean, correct removal of two dead placeholder menu links (`href="#"` Profile and Settings) that had no backing functionality. The dropdown still renders correctly with the `player`-gated Sign in/Sign out link, and the mobile panel was never affected. ## Summary This PR removes the non-functional "Profile" and "Settings" placeholder links from the account dropdown in `app/templates/v3/base.html`, resolving #526. It's a purely subtractive template edit with no logic changes and nothing left dangling. Looks good — ship it. (Nit, non-blocking and pre-existing, not introduced here: the remaining Sign in / Sign out links in `app/templates/v3/base.html:63` and `:65` are still `href="#"` stubs. If they're also unwired, they may be worth tracking in a follow-up, but that's outside the scope of this change.)
johnsturgeon deleted branch remove-profile-and-settings-pages-from-the-v3-profile-pic-526 2026-09-13 19:35:21 +02:00
Sign in to join this conversation.
No description provided.