This is a well-scoped, content-only PR: a new v3 rules page template, a regenerated Tailwind CSS bundle to cover the new utility classes it uses, and the accompanying minor version bump. I verified the scoring simulator's twelve outcome tables against the described rules and against the actual autopick behavior in app/picks.py, and they're all correct.

Summary

The rules page renders through the existing v3_rules route (app/routers/v3.py:134) and the CSS/version changes are consistent with it. The only thing I'd flag is a small markup slip; everything functional checks out.

Nits

app/templates/v3/rules.html:257 — the first  in the "Autopick explained" section is never closed before the next  opens on line 259. Browsers auto-close it so it renders acceptably, but it's malformed markup and worth tidying:
```

 What happens if you don't get your picks in before kickoff? Autopick to the rescue.

```
Add the closing  after the span.

Notes (non-blocking, verified fine)

Scoring simulator: I checked all twelve group-has-[...] result tables (rules.html:139-253) against the stated rules — mandatory lock (+1/−1), optional upset (+1/no penalty), straight-up win. Every Win/Loss/Bonus/Total combination is consistent, including the lock-and-upset compound cases.
Autopick copy accurately matches the code: _append_auto_picks defaults to game.home_team_id (app/picks.py:137), and the underdog-only upset restriction is reflected by giving the favored-team (49ers) upset select a "None"-only list.
Using name="scenario" on the two <details> elements makes them a mutually-exclusive accordion, which is the intended behavior — good.
Version bump 2.35.0 → 2.36.0 with matching uv.lock update follows the per-PR versioning convention in CLAUDE.md.

Looks good to merge once the stray  is closed.

This is a well-scoped, content-only PR: a new v3 rules page template, a regenerated Tailwind CSS bundle to cover the new utility classes it uses, and the accompanying minor version bump. I verified the scoring simulator's twelve outcome tables against the described rules and against the actual autopick behavior in `app/picks.py`, and they're all correct. ## Summary The rules page renders through the existing `v3_rules` route (`app/routers/v3.py:134`) and the CSS/version changes are consistent with it. The only thing I'd flag is a small markup slip; everything functional checks out. ## Nits - `app/templates/v3/rules.html:257` — the first `` in the "Autopick explained" section is never closed before the next `` opens on line 259. Browsers auto-close it so it renders acceptably, but it's malformed markup and worth tidying: ```html What happens if you don't get your picks in before kickoff? Autopick to the rescue. ``` Add the closing `` after the span. ## Notes (non-blocking, verified fine) - Scoring simulator: I checked all twelve `group-has-[...]` result tables (`rules.html:139-253`) against the stated rules — mandatory lock (+1/−1), optional upset (+1/no penalty), straight-up win. Every Win/Loss/Bonus/Total combination is consistent, including the lock-and-upset compound cases. - Autopick copy accurately matches the code: `_append_auto_picks` defaults to `game.home_team_id` (`app/picks.py:137`), and the underdog-only upset restriction is reflected by giving the favored-team (49ers) upset select a "None"-only list. - Using `name="scenario"` on the two `<details>` elements makes them a mutually-exclusive accordion, which is the intended behavior — good. - Version bump 2.35.0 → 2.36.0 with matching `uv.lock` update follows the per-PR versioning convention in CLAUDE.md. Looks good to merge once the stray `` is closed.

johnsturgeon added 1 commit

2026-09-12 17:57:05 +02:00

[skip review] Updated version for prod release

Claude Code Review / claude-review (pull_request) Successful in 3s

Details

Python FastAPI Jinja Linting / build (pull_request) Successful in 30s

Details

Tests / pytest (pull_request) Successful in 15s

Details

faf748ed8e

johnsturgeon added 1 commit

2026-09-12 17:58:18 +02:00