picks_form swallows every IntegrityError as a duplicate submission #438

New issue

Closed

opened 2026-08-31 16:42:58 +02:00 by johnsturgeon · 0 comments

johnsturgeon commented

2026-08-31 16:42:58 +02:00

Owner

    try:
        session.commit()
    except sqlalchemy.exc.IntegrityError:
        # Race condition: concurrent submission passed the earlier check
        session.rollback()

The comment describes uq_playergamepick_player_game, but the handler catches every constraint on the table — NOT NULLs and uq_one_lock_per_week included — then renders the success template.

That is how the missing week_id went unnoticed: every pick failed the NOT NULL check, rolled back as a "race", and the page said it worked.

Narrow it to the unique constraint, or at minimum log before swallowing.

```python try: session.commit() except sqlalchemy.exc.IntegrityError: # Race condition: concurrent submission passed the earlier check session.rollback() ``` The comment describes `uq_playergamepick_player_game`, but the handler catches every constraint on the table — NOT NULLs and `uq_one_lock_per_week` included — then renders the success template. That is how the missing `week_id` went unnoticed: every pick failed the NOT NULL check, rolled back as a "race", and the page said it worked. Narrow it to the unique constraint, or at minimum log before swallowing.

johnsturgeon referenced this issue

2026-09-01 18:51:28 +02:00

Sweep TECH_DEBT entries the control loop and #440 resolved #441

johnsturgeon added this to the Kickoff 2026 milestone

2026-09-02 14:47:12 +02:00

johnsturgeon referenced this issue from a commit

2026-09-02 14:54:12 +02:00

We now log what happened, and raise

johnsturgeon referenced this issue from a pull request that will close it,

2026-09-02 14:54:19 +02:00

We now log what happened, and raise #449