No tests for the Tank01 client retry path #437

New issue

Closed

opened 2026-08-31 16:42:56 +02:00 by johnsturgeon · 0 comments

johnsturgeon commented

2026-08-31 16:42:56 +02:00

Owner

_http_get_with_retry (app/tank01_api/client.py) handles transient 501/502/503, httpx.RequestError, and exponential backoff. It has no coverage.

The equivalent tests existed as TestRetries in tests/test_tank01_api.py and went out with that file when NflApi was deleted. tests/test_tank01_client.py covers shapes and params but never a non-200.

Worth having: this is a metered API on someone else's infrastructure.

`_http_get_with_retry` (`app/tank01_api/client.py`) handles transient 501/502/503, `httpx.RequestError`, and exponential backoff. It has no coverage. The equivalent tests existed as `TestRetries` in `tests/test_tank01_api.py` and went out with that file when `NflApi` was deleted. `tests/test_tank01_client.py` covers shapes and params but never a non-200. Worth having: this is a metered API on someone else's infrastructure.

johnsturgeon referenced this issue

2026-09-01 18:51:28 +02:00

Sweep TECH_DEBT entries the control loop and #440 resolved #441

johnsturgeon closed this issue

2026-09-07 13:42:34 +02:00